Conversation
|
@X30N1 Again, as Fluxer is down, can you give feedback on this here? |
AmilieDev
added
enhancement
bot_token.txt
Outdated
| @@ -1 +1 @@ | |||
| Replace this text with the bot token. No quotes, just the raw token. | |||
| 1475487891326190011.0Bc-deazq5P6XXzj0ALD7yBsMPUCsB9yiNzXQhzUbKw No newline at end of file | |||
There was a problem hiding this comment.
TOKEN IN SETUP FILE, REMOVE AND REGENRATE TOKEN IMMEDIATELY
To prevent repeated occurances add file to .gitignore
| @@ -6,28 +6,28 @@ services: | |||
| restart: unless-stopped | |||
| environment: | |||
| # Set this to true if you want to configure using the docker-compose deployment method | |||
| DOCKER_DEPLOY: false | |||
| DOCKER_DEPLOY: "false" | |||
There was a problem hiding this comment.
Bools aren't meant to be in quotes,
revert unless you set the main script to parse a string instead of boolean
docker-compose.yml
Outdated
| BOT_DEBUG_MODE: 0 | ||
| # Set this to your guild admins ID, this is necessary for MANY commands such as roleall. | ||
| ADMIN_ID: "INSERT ADMIN ID HERE" | ||
| ADMIN_ID: "1473331082336444455" |
There was a problem hiding this comment.
Revert all set config files and add docker-compose.yml to local .gitignore. This file can always be edited directly from github.
There was a problem hiding this comment.
Should be allright.
For future reference: Don't extend this to file storage. python is not fast at repeated operations, use a DB or Cpython instead.
|
I don't have write access so I cannot approve a build to be pulled, but yeah now that OPSEC is handled I don't see any bigger issues at play right now. Not that I can test it, fluxer's down :p Edit: Don't forget to regen the token once fluxer's back up! The commit is here to stay now as a mark of shame lol. |
|
Also since I don't have write access and can't fix it anyways, there's one issue you could fix right now: While recreating the loading mechanism on my bot I noticed you don't explicitly handle trying to load a loaded cog, which can be fixed pretty easily with if self.bot.get_cog(cog):
print("smthn")
continueSo add that when you have the time |
X30N1
left a comment
X30N1
left a comment
There was a problem hiding this comment.
Second review as now I can approve PR's
|
@X30N1 all those files you Yelled at me about were deleted, the token has been regenerated :p silly me |
|
Holding PR for a minute now, while I work on the self bot get cog fix. |
|
ok githyub. |
2 participants
Not completed, but must be worked with however and can be modified at a later time to work better. Code is most definitely not the best, flat.