This repository was archived by the owner on Oct 6, 2025. It is now read-only.
Open
Conversation
chrismacklin
suggested changes
May 7, 2019
Contributor
chrismacklin
left a comment
chrismacklin
left a comment
There was a problem hiding this comment.
Nice improvement, will merge after tweaks.
src/AmyrisBio/biolib.fs
Outdated
| (End, { trigram="End" ; letter = '*' ; hydrophobicity = None }) | ||
| ] |> Map.ofList | ||
|
|
||
| let aaLetterToSymbolic (aa:char) = |
Contributor
There was a problem hiding this comment.
Please rename as aaLetterToSymbol for consistency,
src/AmyrisBio/biolib.fs
Outdated
| | 'Y' -> Tyr | ||
| | 'W' -> Trp | ||
| | '*' -> End | ||
| | _ -> failwithf "ERROR: unknown amino acid letter '%c' in aaLetterToSymbolic" aa |
Contributor
There was a problem hiding this comment.
Could we use the Result type here instead of raising an exception?
Contributor
There was a problem hiding this comment.
If it must be an exception, let's either use a more specific exception class or declare a custom exception type.
src/AmyrisBio/biolib.fs
Outdated
|
|
||
|
|
||
| /// Translates amino acid represented with one character to a trigram, eg 'W' -> "Trp" , '*' -> "End" | ||
| let aaTrigramToSymbolic (aa:string) = |
src/AmyrisBio/biolib.fs
Outdated
| | "Tyr" -> Tyr | ||
| | "Trp" -> Trp | ||
| | "End" -> End | ||
| | _ -> failwithf "bad aa '%s' in aaLetterToSymbolic" aa |
Contributor
There was a problem hiding this comment.
Result type here as well would be nice.
…mments MIN: addressed review comments
Contributor
@chrismacklin , i have addressed all your comments and updated this PR. I think this PR would be easier to be merged before the migration to .net core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small extension to the amino acid representation / handling, a severely neglected corner of our basic representation, that puts the letter e.g. 'K' , symbolic Lys and trigram "Lys" forms on same footing and allows interconversion. Also pulls in some common properties and references. I keep on rewriting standalone versions of this all the time, so contributing back something more permanent