Skip to content

Comments

allow use of is_integrated_over_time#6

Draft
jpfon wants to merge 3 commits intomainfrom
dsc-1383
Draft

allow use of is_integrated_over_time#6
jpfon wants to merge 3 commits intomainfrom
dsc-1383

Conversation

@jpfon
Copy link
Collaborator

@jpfon jpfon commented Feb 6, 2026

fix(ODESimulationProperties-and-DynamicFBASimulator): allow use of is_integrated_over_time

for David and Thomas

@jpfon jpfon requested a review from Copilot February 6, 2026 11:23
@jpfon jpfon self-assigned this Feb 6, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the is_integrated_over_time flag in ODE simulation properties and the dynamic FBA simulator. The change allows users to specify whether a flux expression should be integrated over time, with a default value of True to maintain backward compatibility.

Changes:

  • Added is_integrated_over_time field to ODESimulationProperties with a default value of True
  • Updated DynamicFBASimulator to pass the is_integrated_over_time flag when adding RHS expressions, with fallback handling for backward compatibility
  • Incremented package version from 0.1.0 to 0.1.1

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/simulib/entities/dynamic.py Added is_integrated_over_time boolean field to ODESimulationProperties class with default value True
src/simulib/methods/dynamic/dfba/simulator.py Wrapped add_rhs_expression call in try-except block to pass is_integrated_over_time flag with fallback for backward compatibility
pyproject.toml Bumped version from 0.1.0 to 0.1.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jpfon and others added 2 commits February 6, 2026 11:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jpfon
Copy link
Collaborator Author

jpfon commented Feb 6, 2026

tests are failing because it uses original dfba package, without changes in model.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants