Conversation
…_integrated_over_time for David and Thomas
There was a problem hiding this comment.
Pull request overview
This PR adds support for the is_integrated_over_time flag in ODE simulation properties and the dynamic FBA simulator. The change allows users to specify whether a flux expression should be integrated over time, with a default value of True to maintain backward compatibility.
Changes:
- Added
is_integrated_over_timefield toODESimulationPropertieswith a default value ofTrue - Updated
DynamicFBASimulatorto pass theis_integrated_over_timeflag when adding RHS expressions, with fallback handling for backward compatibility - Incremented package version from 0.1.0 to 0.1.1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/simulib/entities/dynamic.py | Added is_integrated_over_time boolean field to ODESimulationProperties class with default value True |
| src/simulib/methods/dynamic/dfba/simulator.py | Wrapped add_rhs_expression call in try-except block to pass is_integrated_over_time flag with fallback for backward compatibility |
| pyproject.toml | Bumped version from 0.1.0 to 0.1.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
tests are failing because it uses original dfba package, without changes in model.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ODESimulationProperties-and-DynamicFBASimulator): allow use of is_integrated_over_time
for David and Thomas