Add md5 hash function#4
Conversation
|
Output looks like this now: |
|
Sure, it may prove useful to some people who download pre-trimmed roms. I see you're using a block size of 1MiB. The original script uses a block size of 100MiB, so if you want you could increase it without worry to make the process faster. |
|
I did this because I was comparing pre-trimmed roms and didnt want to pad them in order to hash them. The hash update() function performance actually drops with the larger block size. I tested a few values starting with the 100MB but finally settled on 1MB. I just did some online research which indicates the optimal block size to feed data into the hash update() function is only 65536. I will do some more tests to compare with that value. What do you think of the format of the output? I can change that as well. And sorry about the closed pull request. I should have just updated it. ** edit ** 1MB is very close but the difference starts to show with larger files. The 15GB file takes about 10 seconds longer. 100MB has the worst performance where the 15GB file takes 60 seconds longer than 65536. |
|
This new code supports file globbing. |
The new function will output the md5 hash of a trimmed file that matches the fully padded rom image so it can be compared to the Scene and No-Intro databases.