Conversation
) the embedding phase (multi-query expansion via cpu-only ollama) can take several minutes. nginx's proxy_read_timeout (60s default) was killing the idle sse connection before any event was flushed, leaving the ui stuck on "retrieving context…" forever. send a sse comment (: keepalive) every 20s to keep the connection alive through the entire pipeline duration.
the setup form was showing the raw otpauth:// url as plain text. users had to manually copy a long secret into their authenticator app. now shows a scannable qr code image (qrcode.react) + keeps the secret as a manual-entry fallback below. also clarifies the step 1 label to mention microsoft authenticator / google authenticator explicitly.
publicApiBaseURL appended /api/v1 onto NEXT_PUBLIC_API_URL, which already contains it, producing a double-prefixed /api/v1/api/v1 request that 404s. Also unmount /respond/:token from requireActivePlan: it ran for any visitor whose browser carries a session cookie (e.g. the workspace owner previewing their own link), 402ing a token-gated public route that vendors with no Retrieva account must reach. Moved both routes to a new unguarded questionnairePublicRoutes router mounted ahead of the plan gate.
…refix fix(questionnaires): fix public vendor form failing to load
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes dev → main. Single change since last main deploy:
publicApiBaseURLappended/api/v1ontoNEXT_PUBLIC_API_URL, which already contains it, producing a double-prefixed/api/v1/api/v1/...request that 404s for the vendor-facing/q/:tokenform.requireActivePlanwas applied to the whole/api/v1/questionnairesmount, including the public/respond/:tokenroutes — 402ing the form when the visiting browser carries a session cookie for an org withplanStatusnot active/trialing (the reporter's org is currentlypaused). Moved both routes to a new unguardedquestionnairePublicRoutes.js, mounted ahead of the plan gate.Fixes the reported error on
https://retrieva.online/q/<token>: "Unable to load questionnaire. Please try again." (see #444 for full details and local validation).Test plan
https://retrieva.online/q/3d6a3e0f-5c80-4258-ae8d-531f0b1a8813and confirm the form loads