Minor updates to library to support msvc and XON/XOFF#53
Merged
AndreRenaud merged 6 commits intoAndreRenaud:masterfrom Nov 4, 2025
Merged
Minor updates to library to support msvc and XON/XOFF#53AndreRenaud merged 6 commits intoAndreRenaud:masterfrom
AndreRenaud merged 6 commits intoAndreRenaud:masterfrom
Conversation
Contributor
Author
|
Please review and merge if applicable |
Owner
|
Any chance you could sneak in the change to the non-windows code, with something like: // clear software flow control
options.c_iflag &= (tcflag_t) ~(IXON | IXOFF | IXANY);
if (HAS_OPTION('X'))
options.c_iflag |= IXON | IXOFF; |
AndreRenaud
reviewed
Oct 28, 2025
simple_uart.c
Outdated
|
|
||
| va_start(ap, logfile); | ||
| len = vasprintf(&buffer, logfile, ap); | ||
| len = vsprintf(buffer, logfile, ap); |
Owner
There was a problem hiding this comment.
Probably should be vsnprintf(buffer, sizeof(buffer)...?
Contributor
Author
There was a problem hiding this comment.
Yeah, that would be more safe. I will fix this.
Owner
|
Thanks for submitting this. Looks reasonable enough. |
Contributor
Author
|
Yeah sure, i will fix it up and resubmit |
Contributor
Author
Yeah sure, i will fix it up |
simple_uart: fix using of vsprintf simple_uart: support flow control on linux
Contributor
Author
|
Hi Andre, i fixed up all the things you pointed out. Please review/merge |
Owner
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Andre,
Here is a small update to the library: