Ci/cpp clang format check example#6
Open
AndrewShkrob wants to merge 15 commits into
Open
Conversation
The iPad should NOT be detected using the trait collections because in the split view the hor size class may be `compact`. Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
And remove deprecated UI_USER_INTERFACE_IDIOM Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
To match swift naming conventions Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Gonzalo Pesquero <gpesquero@yahoo.es>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
[generator][indexer][android][ios] Charging station maximum power Signed-off-by: Arthur Matteson <info@battery.ac>
Signed-off-by: Arthur Matteson <info@battery.ac>
Signed-off-by: Arthur Matteson <info@battery.ac>
Signed-off-by: Arthur Matteson <info@battery.ac>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return format(hours); | ||
| } | ||
|
|
||
| std::string MetadataTagProcessorImpl::MaxChargingPower(std::string_view const & previousMetadata, std::string const & k, std::string v) |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| std::string MetadataTagProcessorImpl::MaxChargingPower(std::string_view const & previousMetadata, std::string const & k, std::string v) | |
| std::string MetadataTagProcessorImpl::MaxChargingPower(std::string_view const & previousMetadata, std::string const & k, | |
| std::string v) |
| std::string_view constexpr kMaxPowerDC{" kW DC"}; | ||
| std::string_view constexpr kMaxPowerAC{" kW AC"}; | ||
| std::string_view constexpr kMaxPowerDelim{", "}; | ||
| char constexpr kMaxPowerPoint='.'; |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| char constexpr kMaxPowerPoint='.'; | |
| char constexpr kMaxPowerPoint = '.'; |
Comment on lines
+484
to
+485
| if (prev.size() > 1) { | ||
| if ((pos = prev.find(kMaxPowerDelim)) != std::string::npos) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| if (prev.size() > 1) { | |
| if ((pos = prev.find(kMaxPowerDelim)) != std::string::npos) { | |
| if (prev.size() > 1) | |
| { | |
| if ((pos = prev.find(kMaxPowerDelim)) != std::string::npos) | |
| { |
| dc = prev.substr(0, pos - kMaxPowerDC.size()); | ||
| ac = prev.substr(pos + kMaxPowerDelim.size(), prev.size() - (pos + kMaxPowerDelim.size() + kMaxPowerAC.size())); | ||
|
|
||
| if (kMaxPowerPoint != '.') { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| if (kMaxPowerPoint != '.') { | |
| if (kMaxPowerPoint != '.') | |
| { |
| std::replace(dc.begin(), dc.end(), kMaxPowerPoint, '.'); | ||
| std::replace(ac.begin(), ac.end(), kMaxPowerPoint, '.'); | ||
| } | ||
| } else if ((pos = prev.find(kMaxPowerDC)) != std::string::npos) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| } else if ((pos = prev.find(kMaxPowerDC)) != std::string::npos) { | |
| } | |
| else if ((pos = prev.find(kMaxPowerDC)) != std::string::npos) | |
| { |
Comment on lines
+620
to
+621
| if (numeric > maximum) { | ||
| if (((mult = part.find('.')) != std::string::npos) && (mult < (part.size() - 2))) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| if (numeric > maximum) { | |
| if (((mult = part.find('.')) != std::string::npos) && (mult < (part.size() - 2))) { | |
| if (numeric > maximum) | |
| { | |
| if (((mult = part.find('.')) != std::string::npos) && (mult < (part.size() - 2))) | |
| { |
|
|
||
| last = pos; | ||
| pos = v.find(split, last + 1); | ||
| } while ((last++) < (v.size() - 1)); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| } while ((last++) < (v.size() - 1)); | |
| } | |
| while ((last++) < (v.size() - 1)); |
Comment on lines
+649
to
+650
| if (!dc.empty()) { | ||
| if (!ac.empty()) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| if (!dc.empty()) { | |
| if (!ac.empty()) { | |
| if (!dc.empty()) | |
| { | |
| if (!ac.empty()) | |
| { |
Comment on lines
+655
to
+656
| prev = dc + static_cast<std::string>(kMaxPowerDC) + static_cast<std::string>(kMaxPowerDelim) + ac + static_cast<std::string>(kMaxPowerAC); | ||
| } else { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| prev = dc + static_cast<std::string>(kMaxPowerDC) + static_cast<std::string>(kMaxPowerDelim) + ac + static_cast<std::string>(kMaxPowerAC); | |
| } else { | |
| prev = dc + static_cast<std::string>(kMaxPowerDC) + static_cast<std::string>(kMaxPowerDelim) + ac + | |
| static_cast<std::string>(kMaxPowerAC); | |
| } | |
| else | |
| { |
| std::replace(dc.begin(), dc.end(), '.', kMaxPowerPoint); | ||
| prev = dc + static_cast<std::string>(kMaxPowerDC); | ||
| } | ||
| } else if (!ac.empty()) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| } else if (!ac.empty()) { | |
| } | |
| else if (!ac.empty()) | |
| { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
organicmaps/android/app/src/main/cpp/app/organicmaps/Framework.cpp
Lines 1456 to 1462 in 982dfe0
There was a problem hiding this comment.
Can it help to remove unused parameters when formatting functions?
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
organicmaps/indexer/ftypes_matcher.cpp
Lines 455 to 482 in 982dfe0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.