Implemented Clean Architecture#35
Open
shalenMathew wants to merge 17 commits intoAndroidEngineers:mainfrom
Open
Implemented Clean Architecture#35shalenMathew wants to merge 17 commits intoAndroidEngineers:mainfrom
shalenMathew wants to merge 17 commits intoAndroidEngineers:mainfrom
Conversation
Author
|
hello sir , can u review the code!!! |
anandwana001
requested changes
Oct 5, 2024
Comment on lines
+29
to
+32
| Scaffold { paddingValues -> | ||
|
|
||
| // ---- | ||
| // providing dependency |
| import com.example.quotesapp.domain.repository.QuoteRepository | ||
|
|
||
| class QuoteRepositoryImplementation:QuoteRepository { | ||
| override fun getQuote(): MutableList<Quote> { |
Contributor
There was a problem hiding this comment.
why returning mutable?
Author
There was a problem hiding this comment.
the library i'm using for for swiping cards decks requires a mutable list
Contributor
There was a problem hiding this comment.
if we think about scaling, what if in future library changes?
the place where we are using library, there we can keep it as mutable, WDYT?
...pp-shalenMathew/app/src/main/java/com/example/quotesapp/domain/repository/QuoteRepository.kt
Outdated
Show resolved
Hide resolved
| .background(Color.Transparent)){ | ||
|
|
||
| Column(modifier = Modifier.wrapContentHeight().fillMaxWidth()) { | ||
| Text(text = "Quote of the day", |
| } | ||
|
|
||
| @Composable | ||
| fun QuoteItemListSection(state: QuoteState, quoteViewModel: QuoteViewModel) { |
Contributor
There was a problem hiding this comment.
why all compose functions in one file?
| import com.example.quotesapp.domain.model.Quote | ||
|
|
||
| data class QuoteState ( | ||
| val data:MutableList<Quote> = mutableListOf(), |
Author
|
hwy there can merge this if there are no conflicts |
Contributor
There was a problem hiding this comment.
Whats BottomNav package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Checklist
README.mdfile with a brief overview of the project, how to set it up, and any relevant information.Screenshots
Quotes App
A simple minimalistic quotes app