nho adds feedback group2 proj3

README.md

@@ -1,4 +1,5 @@
 # README
+<!-- NHO: missing README  -->
 
 This README would normally document whatever steps are necessary to get the
 application up and running.

app/controllers/application_controller.rb

@@ -1,4 +1,3 @@
 class ApplicationController < ActionController::Base
-  # protect_from_forgery with: :exception
   protect_from_forgery with: :null_session, if: Proc.new { |c| c.request.format == 'application/json' }
 end

app/controllers/places_controller.rb

@@ -1,12 +1,17 @@
 class PlacesController < ApplicationController
   def index
     @places = Place.all
-    respond_to do |format|
-      format.json { render json: @places }
-    end
+    # NHO: since you will not be serving HTML with this app, you can remove the respond_to block
+    # and only render json, i.e:
+
+    # respond_to do |format|
+    #   format.json { render json: @places }
+    # end
+    render json: @places
   end
 
   def show
+    # NHO: shouldn't this be .findy_by so it will return an object and not an array?
     @place = Place.where(zip: params[:id])
     respond_to do |format|
       format.json { render json: @place }
@@ -16,18 +21,25 @@ def show
   def create
     @place = Place.new(place_params)
     respond_to do |format|
+      # NHO: nice validation checking, the only thing I might be conscious of
+      # is to rendering the same type of data from the controller
+      # ie. if it saves, we get back an object, but if it doesnt, we get back an array
+      # this will lead to more logic on the front end
       if @place.save!
         format.json { render json: @place }
       else
+        # NHO: could render the last error message so you get back just an object
         format.json { render json: @place.errors }
       end
     end
   end
 
+  # NHO: missing update
+
   def destroy
     @place = Place.find_by(zip: params[:id])
     @place.destroy
-    render json: {"status": "deleted"}
+    render json: {status: "deleted"}
   end
 
   private

app/models/place.rb

@@ -1,3 +1,4 @@
 class Place < ApplicationRecord
+  # NHO: this code looks a little out of place...
   # skip_before_action :verify_authenticity_token
 end