Skip to content

✨🏢 Add foster families emergencies#757

Open
sbellavoine wants to merge 2 commits intodevfrom
tec-111-foster-family-emergencies
Open

✨🏢 Add foster families emergencies#757
sbellavoine wants to merge 2 commits intodevfrom
tec-111-foster-family-emergencies

Conversation

@sbellavoine
Copy link
Collaborator

No description provided.

Copy link
Member

@simonrelet simonrelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop forte!

updatedAt DateTime @updatedAt
activities Activity[]

emergencies FosterFamilyEmergencies @default(UNKNOWN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il y a une raison particulière pour utiliser une enum à la place d'un boolean ? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas forcément, je me suis basée sur un exemple, il me semble que c'était celui des jardins 🤔

FosterFamilyEmergencies,
React.ReactNode
> = {
[FosterFamilyEmergencies.NO]: <Icon href="icon-tree-slash-solid" />,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais te fournir les icons a utiliser ici 👌

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci ! :)

[FosterFamilyEmergencies.UNKNOWN]: <Icon href="icon-tree-question-solid" />,
};

export function EmergenciesIcon({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas l'impression que ce composant soit utilisé.
Tu l'utilises quelque part ? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectivement... Je me suis basée sur le Form.Field pour les types de logements. Je vais le supprimer :)


<Separator />

<Emergencies defaultFosterFamily={defaultFosterFamily} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je mettrais bien ce champs juste après la disponibilité

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je fais la modif :)

);
}

function Emergencies({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function Emergencies({
function EmergenciesField({

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !


<SimpleItem icon={<Icon href="icon-hand-holding-heart-solid" />}>
<Markdown components={HIGHLIGHT_COMPONENTS}>
{[TEXT_BY_EMERGENCY[fosterFamily.emergencies]].join("")}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{[TEXT_BY_EMERGENCY[fosterFamily.emergencies]].join("")}
{TEXT_BY_EMERGENCY[fosterFamily.emergencies]}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants