Fix frontend API URL to use internal backend DNS#1
Open
railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
Open
Fix frontend API URL to use internal backend DNS#1railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
getApiBaseUrl()function infrontend/src/lib/api.tsfell back towindow.location.hostname:8000whenNEXT_PUBLIC_API_BASE_URLwas unset. In production this constructedhttp://reliable-caring-production-f609.up.railway.app:8000, which is the frontend's own public hostname on the wrong port — the backend is not reachable there.Solution
Replaced the
window.locationfallback with a server-side branch that returnsprocess.env.SPHERE_BACKEND_URL(matching the pattern already used in_lib/upstream.ts) or hard-falls back tohttp://thesphere.railway.internal:8000— the backend's Railway-internal DNS address. Client-side (browser) requests in local development still fall through tohttp://localhost:8000. TheNEXT_PUBLIC_API_BASE_URLoverride continues to take highest priority for any explicit configuration.Changes
frontend/src/lib/api.tsGenerated by Railway