Use NEXT_PUBLIC env vars for API URLs without hardcoding#4
Open
railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
Open
Use NEXT_PUBLIC env vars for API URLs without hardcoding#4railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
railway-app[bot] wants to merge 1 commit intohosting-railwayfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The frontend hardcoded
http://localhost:8000as the default in the Dockerfile ARG declarations, meaning the baked-in build artifact always pointed at localhost regardless of what Railway injected. Additionally,NEXT_PUBLIC_API_URLandNEXT_PUBLIC_WS_URLwere not recognised as fallback sources in eitherapi.tsorintelligence/client.ts, and there was nogetWebSocketUrl()helper for deriving WebSocket URLs from the configured API base.Solution
Removed the
=http://localhost:8000and=ws://localhost:8000defaults from the Dockerfile ARGs so Railway-injected values are never silently overridden. ReplacedNEXT_PUBLIC_WS_BASE_URLwith the correctly namedNEXT_PUBLIC_WS_URLand addedNEXT_PUBLIC_API_URLas a recognised ARG/ENV. UpdatedgetApiBaseUrl()inapi.tsandresolveBaseUrl()inintelligence/client.tsto checkNEXT_PUBLIC_API_BASE_URLfirst, thenNEXT_PUBLIC_API_URL, then fall back to the hostname-derived localhost. AddedgetWebSocketUrl()toclient.tsthat honoursNEXT_PUBLIC_WS_URLand deriveswss:///ws://from the resolved API URL when the env var is absent.Changes
frontend/src/lib/api.tsfrontend/src/lib/intelligence/client.tsinfra/docker/frontend.DockerfileGenerated by Railway