feat: add signed meter metadata payloads#701
Merged
AnnabelJoe merged 2 commits intoJul 3, 2026
Merged
Conversation
- Add MeterMetadata type and computeMetadataHash() to crypto lib - Extend ReadingSchema to accept optional metadata + metadata_signature_hex - Verify Ed25519 metadata signature in POST /api/readings - Persist metadata, metadata_hash, metadata_signature_hex on readings row - Add migration 003 for new readings columns - Update send-reading.mjs to sign and send --firmware/--model/--manufacturer
|
@jessicanath Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #547
Extends the meter reading payload to support optional device metadata (firmware version, hardware model, manufacturer, GPS coordinates), signed by the meter's Ed25519 key — so metadata is as tamper-evident as the reading itself.
Changes
lib/crypto.ts— addsMeterMetadatainterface andcomputeMetadataHash()(SHA-256 of sorted-key canonical JSON)api/readings/route.ts— acceptsmetadata+metadata_signature_hex; verifies Ed25519 sig before persisting; validates that sig is present when metadata is includeddatabase.types.ts— addsmetadata,metadata_hash,metadata_signature_hexcolumns toreadingsRow/Insert typesdocs/migrations/003_meter_metadata.sql—ALTER TABLE readingsmigration for the three new columns + index onmetadata_hashscripts/send-reading.mjs— adds--firmware,--model,--manufacturerflags; builds + signs metadata hash automaticallyWhat was tested