Open
Conversation
mtgnoah
reviewed
Mar 28, 2025
mtgnoah
reviewed
Mar 28, 2025
mtgnoah
reviewed
Mar 28, 2025
mtgnoah
reviewed
Mar 28, 2025
mtgnoah
reviewed
Mar 28, 2025
| acknowledged: Vec<D>, | ||
|
|
||
| //TODO: replace the following two | ||
| accepted: Archive<TwoCap, D, B, R>, |
Author
There was a problem hiding this comment.
these two are blocked by the storage work, and can replace once they are done
mtgnoah
reviewed
Mar 28, 2025
manojkgorle
reviewed
Mar 31, 2025
| return; | ||
| } | ||
|
|
||
| self.txs.push(payload); |
There was a problem hiding this comment.
If partitioning of txs isn't done, doesnt it result in easy abusing the network and reducing practical bandwidth?
Author
There was a problem hiding this comment.
yep it is, ideally there should be some api nodes connect to the consensus nodes to do the partitioning
| self.txs.push(payload); | ||
| let _ = response.send(true); | ||
| }, | ||
| // batch ackowledged by the network |
| waiters.entry(digest).or_default().push(response); | ||
| }, | ||
| Message::GetBatchContainTx { digest, response } => { | ||
| // TODO: optimize this naive way of seaching |
| } | ||
| }, | ||
| Message::GetTx { digest, response } => { | ||
| // TODO: optimize this naive way of seaching |
|
Nice work! LGTM. Just a few nits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mempool functionality that utilizes broadcast commonware/broadcast primitive, it implements exactly the same functionality as described in blog: https://commonware.xyz/blogs/commonware-broadcast.html, where one block references batches of txs and there exists multiple txs sequencer that sequence batches through the broadcast primitive.
A batch will be added to a mempool only when it is acknowledged and they are added in the original order the txs sequencer sequence. Acknowlegements of batches are pushed to a FIFO, which will be used for
ConsumeBatchesandConsumedBatchesoperations to pick up & consume batches in order.The correctness is guaranteed that