[Block commit hash] added functionality for securely signing & sending block commit hash.#3
Open
manojkgorle wants to merge 100 commits intoAnomalyFi:mainfrom
Open
[Block commit hash] added functionality for securely signing & sending block commit hash.#3manojkgorle wants to merge 100 commits intoAnomalyFi:mainfrom
manojkgorle wants to merge 100 commits intoAnomalyFi:mainfrom
Conversation
Signed-off-by: Noah Pravecek <noahpravecek@gmail.com>
Signed-off-by: Noah Pravecek <noahpravecek@gmail.com>
Block commit hash
Author
|
Error is not with the proposer monitor. P chain stops producing blocks after a few empty blocks. (not a production case) Found a bug that may cause problems in prod. fixing that. |
changing getcanonicalvalidatorset visibility
prefix changes
changes to rpc client & server to support blockcommit hash prefix
Author
|
Been testing with the latest version on hypersdk, as this fork of hypersdk can not be run due to this needing eth API. Should test this version specifically once aws access is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes & Testing done.
Future optimization consideration:
instead of using proposerMonitor.Validator, access validators from snowCtx directly. (this fails when the proposer monitor refreshes). For < 30 seconds, when a validator w stake has been added, we may not consider that validator due to the proposer monitor not getting refreshed.Todo:
innerBlockCommitHash.blockcommithashcan not be stored.splitviewof validator set.