Skip to content

Tbc Trinket/Enchant rules and Arbitrary text fixes#15

Open
gregcarmo wants to merge 6 commits into
Anonomit:mainfrom
gregcarmo:tbc-trinket-fix
Open

Tbc Trinket/Enchant rules and Arbitrary text fixes#15
gregcarmo wants to merge 6 commits into
Anonomit:mainfrom
gregcarmo:tbc-trinket-fix

Conversation

@gregcarmo

Copy link
Copy Markdown
Contributor

Changes (focused and tested on TBC Anniversary)

1. Custom Trinket and Enchant Rules (TBC)

  • Added a wide range of TBC trinket procs and enchants to use user-configured aliases.
    • Added under TBC rules cause not sure it applies to other expansions

2. Inline Stat Changes

  • Alias Matching: Switched from GetNormalName to GetAlias when scanning inline stats. This ensures it matches against the alias and not the default names (trinkets and enchants works now with alias)
  • Single-Digit stats: Changed pattern from %d+[%d,%.]+ to %d[%d,%.]*. Fixing single digit stats beings skipped.
  • Respect Custom Colors: The inline parser now respects user-configured custom stat colors (self:GetOption("color", stat)) and individual stat toggles (doRecolor) rather than strictly using default colors.
  • Overlaping stats: Rewrote the overlapping replacement resolution. Will filter the overlap and apply the remaining valid replacements instead of discarding the entire line.
    • This was needed for trinket procs and enchants with multiple stats.
  • Socket Exclusions: With my changes sockets were getting partial or false positive recolors, so I disabled it for now (could add rules for socket stats later)

3. Enchant Consumables Tooltip Fix

  • Added a text-based check (IsPermanentEnchantText) to look for the word "Permanently" (disclaimer: added some localized versions of the word "Permanently" using AI)
  • Disables rewording and recoloring for permanent enchant items like those you get from reputation vendors, crafted and other usable enchants, only rewording and recoloring them when used on items
  • Once the enchant is applied to an item, it displays as a normal stat line (without the "Use: Permanently..." string) and will still reword and recolor on the gear as expected.

4. Disclaimer

All my changes were made and tested on TBC Anniversary, if you think they are not good or could break other versions or the addon in general feel free to reject the PR. I made them mostly for myself cause I can't play using normal tooltips anymore lol.

5. Some examples

  • Echants
    • image
  • Proc trinkets
    • image
image

Fix: Stat Coloring

- DPS and Healing trinkets

- Some enchants

- Exclude Sockets from recoloring

- Fix GetNormalName() to GetAlias() to more easily reword and recolor on abritrary text after change on upstream
…instead of base

- Added and modified a bunch of TBC trinkets and enchants to use user alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant