Make _handle param f positional-only to avoid form field collision#895
Open
lisadlima wants to merge 1 commit into
Open
Make _handle param f positional-only to avoid form field collision#895lisadlima wants to merge 1 commit into
lisadlima wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #834
fas a parameter triggersTypeError: _handle() got multiple values for argument 'f', because the form fieldfarrives via**wreqand collides with_handle's positionalf(the handler itself).Makes
fpositional-only with/:async def _handle(f, /, *args, **kwargs). This is the standard stdlib idiom (functools.partial,functools.reduce) and is preferable to renaming (e.g._f), which only relocates the collision to a different field name.notebook fasthtml/nbs/api/00_core.py was edited, synced (not
core.pydirectly), cleaned. Test is innbs/api/00_core.ipynbright under _handle.