Skip to content

πŸ”’ Fix Cross-Site WebSocket Hijacking (CSWSH) vulnerability in server.py#13

Open
Ap-0007 wants to merge 1 commit into
mainfrom
security-fix-cors-socketio-5294131655343495225
Open

πŸ”’ Fix Cross-Site WebSocket Hijacking (CSWSH) vulnerability in server.py#13
Ap-0007 wants to merge 1 commit into
mainfrom
security-fix-cors-socketio-5294131655343495225

Conversation

@Ap-0007

@Ap-0007 Ap-0007 commented May 18, 2026

Copy link
Copy Markdown
Owner

🎯 What: Removed the cors_allowed_origins="*" parameter from the SocketIO initialization in server.py.

⚠️ Risk: The application allows remote control of the host device (mouse movement, clicking, keyboard typing, executing system scripts) via WebSockets. By setting cors_allowed_origins="*", any malicious website visited by a user on their network could silently connect to the local WebSocket server and hijack the session (Cross-Site WebSocket Hijacking), gaining full remote control of the machine without the user's consent.

πŸ›‘οΈ Solution: By removing this argument, Flask-SocketIO defaults to the secure same-origin policy. This strictly ensures that only the application's legitimate frontend (which is served from the same domain and port) can interact with the WebSocket server, eliminating the attack vector from arbitrary websites.


PR created automatically by Jules for task 5294131655343495225 started by @Ap-0007

Removed the `cors_allowed_origins="*"` argument from the Flask-SocketIO initialization. This enforces the default same-origin policy, mitigating the risk of Cross-Site WebSocket Hijacking (CSWSH).

Co-authored-by: Ap-0007 <200978133+Ap-0007@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
side_pro Ready Ready Preview, Comment May 18, 2026 1:12pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant