Skip to content

⚡ Optimize Island Visit Query to Single Fetch #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ap-0007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize Island Visit Query to Single Fetch #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions app/api/visit/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,30 +27,16 @@ export async function POST(request: NextRequest) {
);
}

// Find island owner
const { data: owner } = await supabase
.from("users")
.select("id")
.eq("username", islandUsername)
.single();

if (!owner) {
return NextResponse.json(
{ error: "Island owner not found" },
{ status: 404 }
);
}

// Find island
// Find island by owner's username
const { data: island } = await supabase
.from("islands")
.select("id")
.eq("user_id", owner.id)
.select("id, user_id, users!inner(username)")
.eq("users.username", islandUsername)
.single();

if (!island) {
return NextResponse.json(
{ error: "Island not found" },
{ error: "Island or owner not found" },
{ status: 404 }
);
}
Expand All @@ -67,7 +53,7 @@ export async function POST(request: NextRequest) {
}

// Don't log visit if visiting own island
if (visitorId === owner.id) {
if (visitorId === island.user_id) {
const { count } = await supabase
.from("visits")
.select("*", { count: "exact", head: true })
Expand Down