Skip to content

πŸ”’ Fix command injection vulnerability in run_osascript#22

Open
Ap-0007 wants to merge 1 commit into
mainfrom
fix-osascript-injection-14570056306568102934
Open

πŸ”’ Fix command injection vulnerability in run_osascript#22
Ap-0007 wants to merge 1 commit into
mainfrom
fix-osascript-injection-14570056306568102934

Conversation

@Ap-0007

@Ap-0007 Ap-0007 commented May 18, 2026

Copy link
Copy Markdown
Owner

🎯 What: Fixed a potential command injection vulnerability in run_osascript within server.py.
⚠️ Risk: The run_osascript function passed arbitrary strings to osascript -e, which allows executing AppleScript commands. If any future modification allowed user input to reach this string unvalidated, an attacker could achieve arbitrary command execution on the host machine by injecting malicious AppleScript (e.g., via do shell script).
πŸ›‘οΈ Solution: Implemented strict allowlisting using a predefined set ALLOWED_SCRIPTS containing only the specific, hardcoded AppleScript commands required by the application. The function now rejects any unauthorized scripts and logs a security error. This guarantees that no user-controlled strings can be evaluated as scripts. Tested and verified in Python.


PR created automatically by Jules for task 14570056306568102934 started by @Ap-0007

Co-authored-by: Ap-0007 <200978133+Ap-0007@users.noreply.github.com>
@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
side_pro Ready Ready Preview, Comment May 18, 2026 2:23pm

@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant