π Fix command injection vulnerability in run_osascript#22
Conversation
Co-authored-by: Ap-0007 <200978133+Ap-0007@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π― What: Fixed a potential command injection vulnerability in
β οΈ Risk: The
run_osascriptwithinserver.py.run_osascriptfunction passed arbitrary strings toosascript -e, which allows executing AppleScript commands. If any future modification allowed user input to reach this string unvalidated, an attacker could achieve arbitrary command execution on the host machine by injecting malicious AppleScript (e.g., viado shell script).π‘οΈ Solution: Implemented strict allowlisting using a predefined set
ALLOWED_SCRIPTScontaining only the specific, hardcoded AppleScript commands required by the application. The function now rejects any unauthorized scripts and logs a security error. This guarantees that no user-controlled strings can be evaluated as scripts. Tested and verified in Python.PR created automatically by Jules for task 14570056306568102934 started by @Ap-0007