XAMPP Fixes#44
Conversation
SmushyTaco
commented
Jan 15, 2025
SmushyTaco
commented
- Updated Docker to replace the broken InstallBuilder link, use a non deprecated image (Ubuntu), and use tcl (tclsh) instead of tclkit for the build process.
- Updated the README.md to include mention of PHP 8.2 and to reflect the transition to tclsh.
- Hardcoded the IBversion because the code to dynamically grab it was trying to get it from a non existent file.
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
You've mode good progress on improving some things.
For other to recognise the value some further explanations are needed.
(I'm not the maintainer of this, just someone taking an interest).
|
|
||
| proc buildProject {project be buildType {license {}} {extraSetVars {}} {onlyGenerateScript 0}} { | ||
| set IBversion [findInstallBuilderVersion $be] | ||
| set IBversion 24.7.0 |
There was a problem hiding this comment.
why is the current findInstallBuilderVersion now not correctly resolving the version?
Are there viable alternatives?
There was a problem hiding this comment.
I'm not very familiar with the tcl language, so I honestly have no idea. This is the solution I was able to come up with, if it isn't sufficient and you know how to better resolve this, please do!
|
The original maintainer seems to have abandoned this project, so I don't see these improvements being merged. Nevertheless, I've updated the InstallBuilder version and if anybody finds a fix to the broken |
|
To follow this PR. |
If I understand the code correctly, it reads a file named To fix / test, create Unfortunately, I currently do not have an environment to test this hypothesis. Hope I can get around to it later and report back. |
|
@DomiWag you're right in your assumption, when I was working on this fix I came across this myself, but the IBVersion largely remains constant, you really only change it if there's an update and you keep it consistent with the version set by the docker file. So it makes no sense to have a file with that name just to supply the version. If that's all that it's there for then it's no different than hardcoding it like I've currently done. The optimal solution would be to change the function to dynamically grab the IB version through the command line so the only place the actual version number would need to specified is in the docker file. |
|
@beltran-rubo: Any progress on this PR done 2025-01-15 by @SmushyTaco? |
|
@beltran-rubo: This PR done 2025-01-15 by @SmushyTaco is more one year! |
4 participants
