fix: Handle missing config file gracefully#26
Open
sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
Open
fix: Handle missing config file gracefully#26sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
Conversation
The load_config() function crashed with FileNotFoundError when the config file didn't exist at ~/.config/task-cli/config.yaml. Changes: - Check if config file exists before attempting to open it - Return empty dict as default when file is missing - Catch OSError/PermissionError and warn on stderr - CLI continues to work without a config file Closes ApexOpsStudio#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the crash when config file is missing (#2).
Problem
load_config()calledopen()on~/.config/task-cli/config.yamlwithout checking if the file exists, causingFileNotFoundError.Fix
config_path.exists()before openingOSError/PermissionErrorwith a warning on stderrCloses #2