refactor: Extract validation to utils module#27
Open
sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
Open
refactor: Extract validation to utils module#27sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
sofia-willow wants to merge 1 commit intoApexOpsStudio:mainfrom
Conversation
Moved scattered validation and helper functions into a single commands/utils.py module for better code organization. Extracted to commands/utils.py: - get_tasks_file() — was duplicated in add.py, list.py, done.py - validate_description() — was in add.py - validate_task_id() — was in done.py All three command modules now import from commands.utils instead of defining their own copies. Tests updated to import from utils. Closes ApexOpsStudio#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts scattered validation logic into a shared
commands/utils.pymodule (#3).What moved
get_tasks_file()commands/utils.pyvalidate_description()commands/utils.pyvalidate_task_id()commands/utils.pyChanges
commands/utils.pywith all shared functions and proper docstringscommands/add.py— imports from utils, removed local copiescommands/list.py— imports from utils, removed local copiescommands/done.py— imports from utils, removed local copiestest_task.py— imports fromcommands.utilsNo behavior changes. All existing functionality preserved.
Closes #3