Skip to content

fix: add missing logger to MSR-1 and MSR-1_BLE#77

Merged
bharvey88 merged 1 commit intobetafrom
fix/add-missing-logger
Mar 7, 2026
Merged

fix: add missing logger to MSR-1 and MSR-1_BLE#77
bharvey88 merged 1 commit intobetafrom
fix/add-missing-logger

Conversation

@bharvey88
Copy link
Contributor

@bharvey88 bharvey88 commented Mar 7, 2026

Version: 26.3.2.1

What does this implement/fix?

Add missing logger: component to MSR-1.yaml and MSR-1_BLE.yaml. MSR-1_Factory.yaml already has it but the other two variants were missing it.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Chores
    • Updated ESPHome integration configuration files to include logger configuration sections for improved system diagnostics and monitoring capabilities.

Add logger: to MSR-1.yaml and MSR-1_BLE.yaml to match
MSR-1_Factory.yaml which already has it.
@github-actions github-actions bot added the bugfix Bug fix label Mar 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a06acb3f-a407-4f8c-b64d-0604d49376bc

📥 Commits

Reviewing files that changed from the base of the PR and between bbd88bc and 071d4e9.

📒 Files selected for processing (2)
  • Integrations/ESPHome/MSR-1.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml

Walkthrough

Two ESPHome integration YAML configuration files receive additions of empty top-level logger: configuration blocks. No existing settings are modified.

Changes

Cohort / File(s) Summary
ESPHome Logger Configuration
Integrations/ESPHome/MSR-1.yaml, Integrations/ESPHome/MSR-1_BLE.yaml
Added empty logger: configuration section to both ESPHome device files, introducing logging configuration blocks with default values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • TrevorSchirmer

Poem

🐰 Whiskers twitch with glee so bright,
Logger blocks now set just right,
ESPHome devices sing with cheer,
Logging config crystal clear! ✨📝

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding a missing logger configuration to two ESPHome YAML files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/add-missing-logger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bharvey88
Copy link
Contributor Author

confirmed working!

@bharvey88 bharvey88 merged commit d52f0fe into beta Mar 7, 2026
12 checks passed
@bharvey88 bharvey88 deleted the fix/add-missing-logger branch March 7, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants