Fix: publish firmware version once on boot instead of polling#31
Fix: publish firmware version once on boot instead of polling#31
Conversation
Per ESPHome dev feedback: the version is a compile-time constant, so publish it once on_boot rather than using a lambda with periodic updates.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR modifies the Apollo Firmware Version sensor's update mechanism across two ESPHome configuration files. It removes the lambda-based dynamic computation from the core definition and disables periodic updates, while adding an explicit on-boot publish action to set the firmware version state. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add text_sensor.template.publish for apollo_firmware_version at priority 500 to PUMP-1_Minimal for dashboard import users.
|
confirmed working! |
Summary
text_sensor.template.publishon bootupdate_interval: neverback to the sensor definition since the value is a compile-time constantPer ESPHome developer feedback: there's no need to poll a constant value every 60s — just publish it once at boot.
Summary by CodeRabbit