Skip to content

Fix: publish firmware version once on boot instead of polling#50

Merged
bharvey88 merged 2 commits intobetafrom
fix/firmware-version-on-boot
Mar 7, 2026
Merged

Fix: publish firmware version once on boot instead of polling#50
bharvey88 merged 2 commits intobetafrom
fix/firmware-version-on-boot

Conversation

@bharvey88
Copy link
Contributor

Summary

  • Replaced the 60s polling lambda with a single text_sensor.template.publish on boot
  • Added update_interval: never back to the sensor definition since the value is a compile-time constant
  • Applied to both R_PRO-1_ETH.yaml and R_PRO-1_W.yaml device variants

Per ESPHome developer feedback: there's no need to poll a constant value every 60s — just publish it once at boot.

Per ESPHome dev feedback: the version is a compile-time constant, so
publish it once on_boot rather than using a lambda with periodic updates.
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@bharvey88 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 154d31a5-a474-4534-8da8-3f1edb4221f3

📥 Commits

Reviewing files that changed from the base of the PR and between e690365 and 9638d32.

📒 Files selected for processing (3)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/R_PRO-1_ETH.yaml
  • Integrations/ESPHome/R_PRO-1_W.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/firmware-version-on-boot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Move text_sensor.template.publish for apollo_firmware_version
from priority 900 to separate priority 500 block in both
R_PRO-1_ETH and R_PRO-1_W variants.
@bharvey88
Copy link
Contributor Author

confirmed working!

@bharvey88 bharvey88 merged commit 4682c77 into beta Mar 7, 2026
8 checks passed
@bharvey88 bharvey88 deleted the fix/firmware-version-on-boot branch March 7, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants