Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new template binary_sensor called Presence (id: combined_presence) was added to the ESPHome configuration. It uses device_class: occupancy and returns the logical OR of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Integrations/ESPHome/Core.yaml`:
- Around line 388-394: The new template binary_sensor "Presence" (id:
combined_presence) just adds an aggregate but does not suppress the original
sources, so Home Assistant will still log id(ld2450_presence) and
id(ld2412_presence); update the earlier definitions of ld2450_presence and
ld2412_presence to be internal/hidden (or set their internal: true / hidden:
true / restore: false as appropriate for ESPHome) or disable their Home
Assistant exposure so only combined_presence is exposed to HA and the logbook
noise is eliminated. Ensure you modify the existing binary_sensor declarations
for ld2450_presence and ld2412_presence (not the new combined_presence block) to
add the chosen hide/internal flag so those sensors stop emitting state changes
to Home Assistant.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c54ab769-39d8-4ae8-974b-d0c7373e2cb9
📒 Files selected for processing (1)
Integrations/ESPHome/Core.yaml
Adds a template binary sensor that combines LD2450 and LD2412 presence into a single occupancy entity. This gives users one clean logbook entry for presence events instead of noise from both individual radar sensors.
722629b to
dc5bf95
Compare
Summary
Test plan
Summary by CodeRabbit