Fix ocean monument bounding boxes shifting on load#472
Open
Kojjyan wants to merge 1 commit intoApollounknowndev:rewrite-squaredfrom
Open
Fix ocean monument bounding boxes shifting on load#472Kojjyan wants to merge 1 commit intoApollounknowndev:rewrite-squaredfrom
Kojjyan wants to merge 1 commit intoApollounknowndev:rewrite-squaredfrom
Conversation
Use the stored offset from NBT during deserialization instead of the current config value, preventing already-generated monuments from being re-shifted when the mod is added or the offset changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467
Tested in 1.21.11.
If you add the Tectonic mod or change its offset setting, ocean monuments that already exist keep their original Y-level. Their bounding boxes do not move. Only newly generated monuments use the offset.
Because of this, each monument’s bounding box always matches the structure’s actual blocks correctly.
How it works: Use the stored offset from NBT during deserialization instead of the current config value, preventing already-generated monuments from being re-shifted when the mod is added or the offset changes.