Skip to content

chore: use prompt#416

Merged
appflowy merged 1 commit into
mainfrom
test_login_option
Jun 25, 2026
Merged

chore: use prompt#416
appflowy merged 1 commit into
mainfrom
test_login_option

Conversation

@appflowy

@appflowy appflowy commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Enhancements:

  • Include the Google OAuth prompt=consent parameter in the authorization URL for sign-in.

@sourcery-ai

sourcery-ai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an explicit OAuth prompt parameter to the Google sign-in redirect URL so that Google always shows the consent screen during authentication.

Sequence diagram for Google sign-in redirect with OAuth prompt

sequenceDiagram
  actor User
  participant WebApp
  participant GotrueService
  participant GoogleOAuth

  User->>WebApp: clickSignInWithGoogle
  WebApp->>GotrueService: signInGoogle(authUrl)
  GotrueService->>GotrueService: build url with provider google
  GotrueService->>GotrueService: append prompt=consent
  GotrueService->>GoogleOAuth: redirectToAuthProvider(url_with_prompt_consent)
Loading

File-Level Changes

Change Details Files
Ensure Google OAuth flow always includes an explicit consent prompt in the authorization URL.
  • Extend the constructed Google OAuth authorize URL to append the prompt=consent query parameter alongside provider and redirect_to.
  • Keep existing logging and redirect behavior unchanged while only modifying the URL query string.
src/application/services/js-services/http/gotrue.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@appflowy appflowy merged commit 98125bf into main Jun 25, 2026
5 of 6 checks passed
@appflowy appflowy deleted the test_login_option branch June 25, 2026 11:19

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider making the prompt=consent behavior configurable or conditional (e.g., only for specific flows or environments) rather than hardcoding it into all Google sign-in requests.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making the `prompt=consent` behavior configurable or conditional (e.g., only for specific flows or environments) rather than hardcoding it into all Google sign-in requests.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant