chore: use prompt#416
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds an explicit OAuth prompt parameter to the Google sign-in redirect URL so that Google always shows the consent screen during authentication. Sequence diagram for Google sign-in redirect with OAuth promptsequenceDiagram
actor User
participant WebApp
participant GotrueService
participant GoogleOAuth
User->>WebApp: clickSignInWithGoogle
WebApp->>GotrueService: signInGoogle(authUrl)
GotrueService->>GotrueService: build url with provider google
GotrueService->>GotrueService: append prompt=consent
GotrueService->>GoogleOAuth: redirectToAuthProvider(url_with_prompt_consent)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the
prompt=consentbehavior configurable or conditional (e.g., only for specific flows or environments) rather than hardcoding it into all Google sign-in requests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the `prompt=consent` behavior configurable or conditional (e.g., only for specific flows or environments) rather than hardcoding it into all Google sign-in requests.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Enhancements:
prompt=consentparameter in the authorization URL for sign-in.