-
Notifications
You must be signed in to change notification settings - Fork 0
New table formats with tooltips #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sande11
wants to merge
12
commits into
131-update-tb-guide-android-app-ui-with-new-figma-design
Choose a base branch
from
new-table-formats-with-tooltips
base: 131-update-tb-guide-android-app-ui-with-new-figma-design
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New table formats with tooltips #153
sande11
wants to merge
12
commits into
131-update-tb-guide-android-app-ui-with-new-figma-design
from
new-table-formats-with-tooltips
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onZoomOut() method call in setupWebView was commented out, to prevent automatic zooming behavior which was causing conflicts in font size persistence and causing content to be pushed to the left of the screen
Added logic to compute and apply chapter icon size in the WebView based on the current font size. This includes setting a CSS variable, tagging relevant images, injecting override styles, and applying inline sizing to ensure consistent scaling even if external styles are missing. The update is triggered after layout and on every page load.
Adds logic to dynamically scale the `.uk-paragraph::before` decorative line in response to text zoom, ensuring consistent appearance. The computed CSS values are injected via a style element in the WebView.
Override attachBaseContext in App and MainActivity to enforce a fontScale of 1.0, preventing system font size changes from affecting the app. Simplify dialog_bookmark_success.xml by replacing the ScrollView with a single TextView and disabling auto-sizing for consistent appearance.
… new-table-formats-with-tooltips
Added new SVG chart icon and updated main.js to enhance tooltip and tab functionality. Refactored style.css for improved color consistency, info icon tooltips, and responsive tab layout. Updated chart.json and HTML pages to reflect new and renamed tables, removed obsolete pediatric dosage tables, and fixed asset paths. These changes improve usability, maintain data accuracy, and enhance the user interface for the TB reference guide.
…rch new highlight color and prefill search bar in bodyfragment Revised and clarified multiple TB guide HTML pages, including table titles, drug dosing, and clinical recommendations. Updated acknowledgements and welcome statements to reflect 2025 redesign. Improved inline search in BodyFragment to prefill search input, show counters, and ensure WebView search listener is set. Adjusted CSS for tooltip positioning and removed unused icon class. Deleted obsolete Table 18 and renamed Table 19 to Table 18 for Grady Hospital TB Isolation Policy.
Introduces a new FontSizeFragment and related layouts for customizable font size settings. Adds a Georgia TB privacy policy HTML asset and updates navigation, settings, and utility classes to support new features. Minor chapter title correction and various UI improvements for preferences.
Caches subchapters for faster toolbar title updates when navigating via in-page links. Enhances WebView fragment/anchor navigation by scrolling to anchors using JavaScript and updating the toolbar title accordingly. Refactors subchapter link handling to improve bookmark type accuracy and fallback navigation.
Revised chart.json to update table IDs and subchapter references for Grady Hospital TB Isolation Policy. Updated HTML content for laboratory diagnosis and TB treatment to fix formatting, clarify recommendations, and correct/expand ART and TB/HIV co-infection guidelines, including timing and drug interaction details. Adjusted tables and notes for accuracy and consistency with current clinical guidelines.
…n' into new-table-formats-with-tooltips
Added custom CSS for opaque, bottom-positioned tooltips in Table 6 for better visibility. Adjusted tooltip positions for info icons in dosage tables and removed redundant tooltips in the treatment regimens page to reduce clutter and improve user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the tab and tooltip UI, as well as various code quality and style enhancements. The most significant change is the addition of interactive info tooltips, which provide contextual information on demand. There are also improvements to color consistency, CSS organization, and tab/tooltip JavaScript logic.
New Features and UI Enhancements:
.info-iconelements with associated.tooltippopups, including click-to-toggle visibility, outside-click dismissal, and support for positioning variants. This allows users to access contextual information in a user-friendly way. [1] [2].with-info-iconutility class for better alignment of icons and text.JavaScript Improvements:
main.jsto use consistent double quotes, improved event handling, and added code for tooltip creation, toggling, and positioning. Also improved tab activation logic for clarity and maintainability. [1] [2] [3]Responsive Design and Table Enhancements:
Minor Content Update:
chapter.json.