Conversation
sneako
reviewed
May 6, 2025
| key: String.t(), | ||
| region: String.t(), | ||
| failover_regions: [String.t()] | nil | ||
| failover_buckets: [[bucket: String.t(), region: String.t()]] | nil |
Member
There was a problem hiding this comment.
let's define a failover_bucket as a new type
Member
There was a problem hiding this comment.
maybe even types for bucket and region since we use them more than once
| failover_regions: [ | ||
| type: {:list, :string}, | ||
| failover_buckets: [ | ||
| type: {:list, :keyword_list}, |
Member
There was a problem hiding this comment.
can you define a a schema for the failover buckets, so that nimble options validates it has the correct key/values?
sneako
reviewed
May 7, 2025
| key: key, | ||
| failover_regions: failover_regions | ||
| } = state | ||
| failover_buckets: failover_buckets |
Member
There was a problem hiding this comment.
Suggested change
| failover_buckets: failover_buckets | |
| failover_buckets: [_|_] = failover_buckets |
just to make sure the list isn't empty. We can get rid of the guard with this change too
sneako
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.