Skip to content

Add some additional config checks #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rconner46 merged 1 commit into from
Jun 3, 2025
+4 −1
Merged

Add some additional config checks #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion auto-sdk-java-integrations/src/main/java/com/applause/auto/helpers/ApplauseConfigHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ public static void validateConfiguration() {
// must be a valid URL
if (sdkConfigBean.useSeleniumGrid()) {
validateUrl(sdkConfigBean.seleniumGridLocation(), true, reqRevDns).ifPresent(errorList::add);
} else if (!sdkConfigBean.useLocalDrivers() && applauseConfigBean.apiKey() == null) {
errorList.add(
"You have not configured an API key for the Applause API. Please set the apiKey property in your system.properties file or as a command line variable.");
}

Set<String> recursiveValueNames =
Expand Down Expand Up @@ -138,7 +141,7 @@ static Optional<String> validateUrl(
}

// Now, if reverse DNS is required, verify the reverse DNS
if (reqRevDns) {
if (reqRevDns && urlAsString != null && !urlAsString.isBlank()) {
return ConfigUtils.verifyReverseDns(urlAsString);
}

Expand Down