AUT-7054 update all deps, bump version, fix linting#49
Merged
noobgramming merged 1 commit intomasterfrom Jul 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Update project version to 6.1.0-SNAPSHOT, bump dozens of dependencies to their latest compatible releases, and clean up linting configuration and suppressions across modules.
- Bump parent and module versions, plus a large matrix of dependencies and plugin versions in all pom.xml files
- Refine SpotBugs and PMD rulesets (add new excludes, remove deprecated rules)
- Remove or add
@SuppressWarningsand@FunctionalInterfaceannotations to satisfy lint rules, and adjust minor code behavior (Gson, charsets, enum logic)
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Bumped project version and updated all dependency & plugin versions |
| build-tools/spotbugs-exclude.xml | Added exclusion for RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
| build-tools/pmdconfig.xml | Removed many deprecated rules, reorganized exclusions |
| auto-sdk-java-framework/src/main/java/.../AbstractDriverManager.java | Removed .setLenient() on GsonBuilder |
| auto-sdk-java-common/src/main/java/.../SwipeDirection.java | Removed default exception branch in enum switch |
Comments suppressed due to low confidence (4)
auto-sdk-java-common/src/main/java/com/applause/auto/data/enums/SwipeDirection.java:60
- The default exception case was removed, so unhandled enum values will now fall through silently. Consider restoring the default branch or explicitly handling invalid values to prevent unexpected behavior.
start = new Point((int) (width * 0.15), height / 2);
auto-sdk-java-framework/src/main/java/com/applause/auto/framework/AbstractDriverManager.java:44
- Removed
.setLenient()changes JSON parsing behavior and may break lenient parsing use-cases. If lenient mode is required, re-add.setLenient()or verify that all JSON inputs conform to strict parsing.
protected static final Gson gsonLenient = new GsonBuilder().create();
auto-sdk-java-config/src/main/java/com/applause/auto/config/PropertyHelper.java:204
- [nitpick] Removing the PMD.CognitiveComplexity suppression may surface complexity warnings here. Consider refactoring this method to reduce complexity or reintroducing a targeted suppression with justification.
static <T extends Config> String callForValueAsString(
auto-sdk-java-testng/src/main/java/com/applause/auto/testng/dataprovider/TestIterationTag.java:25
- [nitpick] Suppressing PMD.AvoidFieldNameMatchingTypeName was removed, which could trigger linter warnings since the field name matches the record name. Consider reintroducing the suppression or renaming the parameter for clarity.
public record TestIterationTag(String testIterationTag) implements ITestIterationTag {
jforkey
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?