fix: prevent command injection in prepare-for-release workflow#159
Open
Kobikg78 wants to merge 1 commit into
Open
fix: prevent command injection in prepare-for-release workflow#159Kobikg78 wants to merge 1 commit into
Kobikg78 wants to merge 1 commit into
Conversation
Pass branch name via environment variable instead of direct shell interpolation to prevent command injection via crafted branch names. Fixes SECENGSW-35
af-dudka
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/prepare-for-release-workflow.yml(SECENGSW-35)steps.vars.outputs.branch) was directly interpolated into shellrun:blocks, allowing arbitrary command execution via a crafted branch nameenv:variable instead, so special characters are treated as data, not shell codeChanges
Determine release tagstep: addedenv: BRANCH_NAMEand replaced${{ steps.vars.outputs.branch }}with${BRANCH_NAME}Commit and Pushstep: same pattern applied to thegit pushcommandBackward Compatibility
No behavioral change for legitimate branch names (e.g.
releases/2.5.1). The version extraction regex and git push destination are identical.Test plan
releases/x.y.zbranch — verify it completes successfullyFixes: SECENGSW-35
🤖 Generated with Claude Code