Skip to content

Change default gesture swipes to desktop switching#270

Open
klovinad wants to merge 1 commit into
AprilNEA:masterfrom
klovinad:proposal/default-desktop-gesture-remap
Open

Change default gesture swipes to desktop switching#270
klovinad wants to merge 1 commit into
AprilNEA:masterfrom
klovinad:proposal/default-desktop-gesture-remap

Conversation

@klovinad

@klovinad klovinad commented Jun 15, 2026

Copy link
Copy Markdown

Summary

Split out from #94 as requested.

This PR changes the default horizontal gesture-button swipes from browser tab switching to desktop/space switching:

  • Left swipe → Previous Desktop
  • Right swipe → Next Desktop

Why

AprilNEA asked to keep this UX decision separate from the wheel-scroll settings work, so each change can be reviewed and reverted independently.

The wheel-scroll settings remain in #94. This PR contains only the default gesture remap.

Verification

  • cargo fmt --all
  • git diff --check

cargo test -p openlogi-core default_gesture_binding --lib was attempted locally, but dependency fetching hung while updating git dependencies before compilation.

@greptile-apps

greptile-apps Bot commented Jun 15, 2026

Copy link
Copy Markdown

Greptile Summary

This PR changes the default left/right swipe gesture actions from tab navigation (PrevTab/NextTab) to virtual desktop switching (PreviousDesktop/NextDesktop). The change applies only to first-run defaults; persisted user configurations are unaffected.

  • The direction mapping (Left → PreviousDesktop, Right → NextDesktop) aligns with the macOS spatial metaphor for Spaces, making it intuitive out of the box.
  • All existing tests in config.rs compare against default_gesture_binding(dir) rather than hardcoded action variants, so they remain valid after this change with no updates required.

Confidence Score: 5/5

Safe to merge — the change is a two-line update to first-run defaults with no impact on saved user configurations.

The only touched code is the default_gesture_binding function, which seeds the UI picker on first run. Existing tests in config.rs compare results against default_gesture_binding(dir) rather than hardcoded action variants, so they stay correct automatically. The new mapping (Left → PreviousDesktop, Right → NextDesktop) matches the macOS Spaces spatial layout and is more broadly useful as a default than browser-tab navigation.

No files require special attention.

Important Files Changed

Filename Overview
crates/openlogi-core/src/binding.rs Two-line default change: left/right swipe gestures now map to PreviousDesktop/NextDesktop instead of PrevTab/NextTab; both Action variants already existed and are tested.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    G[Gesture Input] --> D{Direction}
    D -->|Up| MC[MissionControl]
    D -->|Down| SD[ShowDesktop]
    D -->|Left| PD[PreviousDesktop ✨ changed]
    D -->|Right| ND[NextDesktop ✨ changed]
    D -->|Click| AE[AppExposé]

    style PD fill:#d4edda,stroke:#28a745
    style ND fill:#d4edda,stroke:#28a745
Loading

Reviews (1): Last reviewed commit: "Change default gesture swipes to desktop..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant