webviewer-barcode sample is working as expected with webviewer v12#112
Merged
Mohammed-AbdulRahman-Apryse merged 10 commits intoJul 8, 2026
Conversation
…annot be invoked without new Replaced legacy function/prototype inheritance: A. Tools.RectangleCreateTool.apply(this, arguments) B. SnipTool.prototype = new Tools.RectangleCreateTool() With proper ES6 class inheritance: A. class SnipTool extends Tools.RectangleCreateTool B. super(...args) in constructor
cropToolGroupButton -> cropToolButton snippingToolGroupButton -> snippingToolButton
Replacing the old way of having custom tool buttons that is ineffective in webviewer v12
- Nested functions more that 4 levels deep - Stateless functional components should not use this
|
Mohammed-AbdulRahman-Apryse
requested review from
AminDodin-Apryse and
hussam-apryse
July 7, 2026 06:22
hussam-apryse
approved these changes
Jul 7, 2026
AminDodin-Apryse
approved these changes
Jul 8, 2026
AminDodin-Apryse
left a comment
AminDodin-Apryse
left a comment
Collaborator
There was a problem hiding this comment.
I tested and the upgrade to v12 is OK, so I'm approving this PR.
However, the sample itself needs re-writing because the non-Apryse barcode libraries it uses are inferior and do not work properly in some cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebViewer v12.0 installation should work the dependencies updates
Recording.2026-07-07.091854.mp4
Resources
https://apryse.atlassian.net/browse/AS-385
Checklist
If you are adding a new sample
lerna.jsonwith the new sample nameIf you are removing an old sample
lerna.json