feat(helm): expose readinessHAMaxLag for HA readiness catch-up gate#15
Conversation
…ArcadeDB #4846) ArcadeDB now gates /api/v1/ready on Raft log catch-up via SERVER_READINESS_HA_MAX_LAG, in addition to the existing readinessRequiresHA leader check. Wire the new observability.health.readinessHAMaxLag value through to -Darcadedb.server.readinessHAMaxLag so operators can tune the follower lag bound. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces the observability.health.readinessHAMaxLag configuration parameter to the ArcadeDB Helm chart, allowing users to specify the maximum Raft log lag for a follower to be considered ready. The review feedback points out a potential issue where a null or omitted value could lead to invalid JVM arguments, and suggests a robust template condition to safely handle defaults while preserving 0 as a valid value.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| {{- end }} | ||
| {{- if $health.readinessRequiresHA }} | ||
| - -Darcadedb.server.readinessRequiresHA=true | ||
| - -Darcadedb.server.readinessHAMaxLag={{ $health.readinessHAMaxLag }} |
There was a problem hiding this comment.
If observability.health.readinessHAMaxLag is omitted or set to null in a user's custom values, rendering {{ $health.readinessHAMaxLag }} directly will result in an empty or <nil> value in the JVM arguments, which can cause startup or parsing failures. Additionally, using a simple default 100 helper would incorrectly override a valid 0 value (since 0 is falsy in Go templates). To handle this robustly, we can define a default fallback that preserves 0 as a valid lag limit.
- -Darcadedb.server.readinessHAMaxLag={{ if or $health.readinessHAMaxLag (eq $health.readinessHAMaxLag 0) (eq $health.readinessHAMaxLag 0.0) }}{{ $health.readinessHAMaxLag }}{{ else }}100{{ end }}
Summary
SERVER_READINESS_HA_MAX_LAG(arcadedb.server.readinessHAMaxLag, default100), gating/api/v1/readyon Raft log catch-up in addition to the existing leader-known check.observability.health.readinessHAMaxLag, emitted alongside-Darcadedb.server.readinessRequiresHA=true(a no-op upstream unless that flag is set).26.7.1hasn't been released yet, so this rides along in the same unreleased version as the observability feature (#4463) it extends.Test plan
helm unittest .— 164/164 passing (3 new cases: default emission, override, and absence whenreadinessRequiresHAis false)helm lint .— clean