Skip to content

fix(#16): fail render when custom plugin has no class#17

Merged
robfrank merged 3 commits into
mainfrom
fix/16-plugins-badly-rendered-if-config-class
Jul 9, 2026
Merged

fix(#16): fail render when custom plugin has no class#17
robfrank merged 3 commits into
mainfrom
fix/16-plugins-badly-rendered-if-config-class

Conversation

@robfrank

@robfrank robfrank commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Closes #16

Summary

When a custom plugin was enabled without a class, the arcadedb.plugin.parameters helper rendered -Darcadedb.server.plugins=<name>:%!s() — Go's formatting error for a nil value — producing a silently broken StatefulSet command. This adds a fail-fast guard in _arcadedb.plugin.ports that mirrors the existing missing-port check, so the render now aborts with a clear message identifying the offending plugin.

Test plan

  • helm unittest charts/arcadedb — full suite passes (165 tests)
  • New case in helpers_test.yaml: custom plugin enabled with a port but no class → failedTemplate with Custom plugin '<name>' has no class specified.
  • Existing case: custom plugin with a class still renders -Darcadedb.server.plugins=<name>:<class>
  • helm lint charts/arcadedb clean

robfrank and others added 2 commits July 9, 2026 09:41
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A custom plugin enabled without a 'class' rendered
-Darcadedb.server.plugins=<name>:%!s() instead of failing, producing a
silently broken StatefulSet command. Add a fail-fast guard mirroring the
existing missing-port check.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where custom plugins without a specified class render a broken configuration flag. It adds a fail-fast validation check in the Helm chart helpers to ensure custom plugins define a class, includes a corresponding unit test to verify this behavior, and documents the issue and its resolution. Additionally, .worktrees/ has been added to the .gitignore file. There are no review comments to address, and no further feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@robfrank robfrank merged commit f2af285 into main Jul 9, 2026
3 checks passed
@robfrank robfrank deleted the fix/16-plugins-badly-rendered-if-config-class branch July 9, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins badly rendered if config.class is not set

1 participant