fix(#16): fail render when custom plugin has no class#17
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A custom plugin enabled without a 'class' rendered -Darcadedb.server.plugins=<name>:%!s() instead of failing, producing a silently broken StatefulSet command. Add a fail-fast guard mirroring the existing missing-port check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where custom plugins without a specified class render a broken configuration flag. It adds a fail-fast validation check in the Helm chart helpers to ensure custom plugins define a class, includes a corresponding unit test to verify this behavior, and documents the issue and its resolution. Additionally, .worktrees/ has been added to the .gitignore file. There are no review comments to address, and no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Closes #16
Summary
When a custom plugin was enabled without a
class, thearcadedb.plugin.parametershelper rendered-Darcadedb.server.plugins=<name>:%!s()— Go's formatting error for a nil value — producing a silently broken StatefulSet command. This adds a fail-fast guard in_arcadedb.plugin.portsthat mirrors the existing missing-portcheck, so the render now aborts with a clear message identifying the offending plugin.Test plan
helm unittest charts/arcadedb— full suite passes (165 tests)helpers_test.yaml: custom plugin enabled with a port but no class →failedTemplatewithCustom plugin '<name>' has no class specified.classstill renders-Darcadedb.server.plugins=<name>:<class>helm lint charts/arcadedbclean