Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the URL used to download PDB files from AlphaFold. This URL was of the form:
f"https://alphafold.ebi.ac.uk/files/AF-{accession}-F1-model_v4.pdb"The change here is simply to switch "v4" to "v6". This change was prompted by my observation that the pipeline was failing due to empty/invalid PDB files. I verified that the "v4" URL was indeed returning empty PDB files, and I manually inferred what I assume is the new/correct AlphaFold URL (it is as simple as changing the "v4" to "v6"). I then manually verified that the downloaded PDBs are valid and that the pipeline works. (I could not find any documentation about this change on the AlphaFold website or repo, hence the manual validation.)
This is also an attempt to address the error reported in #97 (but it's not yet clear that the error there is related).
PR checklist
Fixes #123, Resolves #456).