Merged
Conversation
ekiefl
approved these changes
Feb 10, 2025
Contributor
ekiefl
left a comment
There was a problem hiding this comment.
I recently wiped my conda envs and started fresh, so I had the opportunity of recreating the development environment for this repo. Everything worked as intended, except there's currently no developer installation instructions, and I think there should be.
conda env create -n ramanalysis-dev --file envs/dev.yml
conda activate ramanalysis-dev
poetry install --no-root --with dev,docs,build
pip install -e .
make testEverything ran without error 👍.
In the example I think you should assume your CWD is the repo root, making the path:
example_data_directory = Path("./ramanalysis/tests/example_data/OpenRAMAN/")
- change example data directory path in usage example as suggested in #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pip install git+<repo url>.Considered building it and releasing it, but not sure if it's ready for that? Would be cool if it were automated!