Merged
Conversation
- add a class method for a "generic" reader that assumes the convention that many vendors abide by in which the first column of a csv file is the wavenumber data and the second column is the intensity data
ekiefl
requested changes
Feb 25, 2025
Contributor
ekiefl
left a comment
ekiefl
left a comment
There was a problem hiding this comment.
This seems sensible. Can you populate the docstring with what you essentially wrote in the PR description?
Collaborator
Author
|
This too seems sensible. |
- add docstring - actually use the wavenumber and intensity index arguments to choose the appropriate columns
ekiefl
approved these changes
Feb 25, 2025
lanery
added a commit
that referenced
this pull request
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a class method for a "generic" reader that assumes the convention that many vendors abide by in which the first column of a CSV file is the wavenumber data and the second column is the intensity data.
The motivation for this is more or less because it's cumbersome to keep adding custom readers for spectrometers when the vast majority of them are structured very similarly and could easily be read with
pandas.read_csv(filename, **kwargs).