mavproxy_signing: allow signing keys with no protocol prefix#1687
Merged
Conversation
An entry of the form "host:port" in ~/.mavproxy/signing.keys now matches a device of the form "proto:host:port" for any protocol (udp, tcp, etc).
peterbarker
approved these changes
May 18, 2026
peterbarker
left a comment
peterbarker
left a comment
Contributor
There was a problem hiding this comment.
Alternatively you could allow globbing instead - less magic.
i.e. *:192.168.1.56:5760
Contributor
Author
I considered that, but I think this is simpler from the users point of view |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entry of the form "host:port" in ~/.mavproxy/signing.keys now matches a device of the form "proto:host:port" for any protocol (udp, tcp, etc).