mavproxy_battery: consume BATTERY_STATUS.voltages_ext to calculate total voltage#1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i connected my flashy 14s smart battery I've seen this in MAVProxy:
42.3 / 14 = 3 V per cell, very bad, I thought the battery was already damaged lol.
The real reason is that mavproxy doesn't consume the
voltages_extinBATTERY_STATUSmessage, so it sums only the first 10 cells to calculate total voltage.With this PR the voltage is calculated properly:
