fix magfit errors#1695
Merged
Merged
Conversation
magfit runs its UI in a child process, which pickles the log via WrapFileHandle. That wrapper assumed text-mode file objects, but a dataflash .bin log is opened in binary mode (_io.BufferedReader), which has no encoding/errors/newlines attributes. This raised "'_io.BufferedReader' object has no attribute 'encoding'". Default those attributes with getattr() in __getstate__, and reopen binary files without the text-only encoding/errors/newline kwargs (which open() rejects in binary mode).
datetime.datetime.utcfromtimestamp() is deprecated. Replace with datetime.datetime.fromtimestamp(tbase, datetime.timezone.utc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pickling errors with modern python