Skip to content

Remove obsolete Rover navigation fields from Basic Tuning#3741

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/remove-out-of-date-fields-rover
Draft

Remove obsolete Rover navigation fields from Basic Tuning#3741
Copilot wants to merge 2 commits into
masterfrom
copilot/remove-out-of-date-fields-rover

Conversation

Copilot AI commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The Rover Basic Tuning page was still surfacing legacy navigation controls that no longer map to current Rover tuning behavior, including WP Overshoot, Lat Acc Cntl Period, and Lat Acc Cntl Damp. This change removes those stale fields so the Navigation section only presents parameters that are still relevant.

  • UI cleanup

    • Removes the obsolete Rover controls from the Basic Tuning Navigation group:
      • WP Overshoot
      • Lat Acc Cntl Period
      • Lat Acc Cntl Damp
    • Collapses the group layout so the remaining navigation fields do not leave empty space.
  • Parameter binding cleanup

    • Stops wiring the removed controls to legacy parameter names in ConfigArdurover.
    • Leaves the remaining Rover navigation controls unchanged.
  • Resource cleanup

    • Removes the associated designer/resource entries for the deleted controls and labels from the Rover configuration view resources.
WP_RADIUS.setup(0, 0, 1, 0.1f, "WP_RADIUS", MainV2.comPort.MAV.param);
TURN_G_MAX.setup(0, 0, 1, 0.1f, new[] { "TURN_MAX_G", "ATC_TURN_MAX_G" }, MainV2.comPort.MAV.param);

// Removed legacy bindings:
// WP_OVERSHOOT
// NAVL1_PERIOD
// NAVL1_DAMPING

Copilot AI changed the title [WIP] Remove out-of-date fields for Rover on Basic Tuning page Remove obsolete Rover navigation fields from Basic Tuning Jun 12, 2026
Copilot finished work on behalf of meee1 June 12, 2026 21:49
Copilot AI requested a review from meee1 June 12, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants