ardupilotmega.xml: mark RADIO as superseded by RADIO_STATUS#505
Merged
Conversation
Author
|
Closes #213 |
khancyr
approved these changes
Jun 1, 2026
Author
|
Added words to correct txbuf meaning |
khancyr
approved these changes
Jun 1, 2026
tridge
requested changes
Jun 1, 2026
| <message id="166" name="RADIO"> | ||
| <description>Status generated by radio.</description> | ||
| <superseded since="2013-06" replaced_by="RADIO_STATUS"/> | ||
| <description>Status generated by radio. Do not use this message, ArduPilot has mis-interpreted the txbuf field in this message for a very long time.</description> |
Collaborator
There was a problem hiding this comment.
remove this, just fix txbuf description
Author
|
Can be merged with tjust the field description change and the superseded line |
ArduPilot considers the txbuf field in the way RADIO_STATUS, not the way RADIO has it.
we looked at the SiK source code - this packet is just the same as RADIO for this field. the SiK source code just chooses to send one of the other depending on whether it has seen a mavlink1 or a mavlink2 packet
peterbarker
force-pushed
the
pr/supersede-RADIO
branch
from
35fa51e to
0c8a490
Compare
github-project-automation
Bot
moved this from ReadyForDevCall
to Done
in Peter's ArduPilot 4.8 Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArduPilot considers the txbuf field in the way RADIO_STATUS, not the way RADIO has it.