Open
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/arenukvern/mcp_flutter~77 Documentation is deployed and generated using docs.page. |
|
Important Review skippedToo many files! This PR contains 289 files, which is 139 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (289)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| VERSION_SOURCE_FILE="$ROOT_DIR/mcp_server_dart/lib/src/core/runtime_version.dart" | ||
| DEFAULT_VERSION="$(sed -nE "s/^const kFlutterMcpVersion = '([^']+)';/\1/p" "$VERSION_SOURCE_FILE")" |
There was a problem hiding this comment.
Install script fails when piped from curl to bash
High Severity
The advertised one-command install (curl -fsSL .../install.sh | bash) will always fail. ROOT_DIR is derived from BASH_SOURCE[0], which is empty when bash reads from a pipe, so it resolves to the user's cwd. VERSION_SOURCE_FILE then points to a nonexistent local path (./mcp_server_dart/lib/src/core/runtime_version.dart), and sed fails on that missing file. Because set -euo pipefail is active, the script terminates immediately. A VERSION file exists at the repo root but is never read by this script.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new release/CI gate automation and a sizeable new live-edit agent service that writes files to disk; failures could impact CI/release publishing or introduce unsafe write behaviors if misused.
Overview
Introduces new CI workflows:
contract_gates.ymlruns Dart tests plus contract checks (docs/help drift, error-code playbook coverage, SDK parity), andrelease.ymlbuilds cross-platform Dart binaries on tag pushes and publishes tarballs +sha256checksums to GitHub Releases.Performs a v3.0.0 hard-cut documentation and versioning update: adds
VERSIONand a largeCHANGELOG.mdentry, converts root markdown docs into short entry points, expands MDX docs (AI-agent and human paths), and documents strict error envelope/connection targeting expectations.Adds a new
flutter_live_editsubsystem (agent + core packages), includingLiveEditAgentServicewith pluggable inference backends, proposal persistence/apply/reject flow, payload compaction for prompts, and accompanying tests and package configs.Written by Cursor Bugbot for commit e1aa237. This will update automatically on new commits. Configure here.