Discussion PR: Full codebase versus empty #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_highlight_dashboard
Fixed typo in file path
Added writing observer install to pytest
Added highlight dashboard module to code
Debugging pytest, working locally on my system but not on github actions
Fixed pytest pip install errors
Fixing modules to work with multiple versions We verify hashes of 3rd party libraries for security reasons. This allows us to support multiple versions of the same file. --------- Co-authored-by: Bradley Erickson <bbwe24@gmail.com>
* Merging update to writing analysis to handle event wrapping. * removed unused methods and linted code * cleaned code up --------- Co-authored-by: DrLynch <cflynch@ncsu.edu>
Added Google API document fetching capability to `latest_data` module in writing observer. This included creating a new runtime object to pass around. Mainly so the Google API can get auth. Additionally created memoization decorator so we don't pull from the Google API too often. This also introduced the need for defining multiple caches via the creds.yaml file. Define a `default` and any other specific KVSs. The default is needed to not break legacy code. The KVS are accessed via enums. See full list of commits from squash: * initial commit for fetching data from google * abstracted document fetch, though the request is still being passed * adjusted redirect_uri string based on feedback * abstracted request to runtime object * added error message to text * cleaned up error message, abstracted retrieve doc * removed caching and set default to not use google plus better closure for future caching * added kvs dictionary with caching for fetching google docs * PR feedback: return errors better, clean up imports, added runtime to other google calls * removed kvs default and added error message about setting main kvs * added kvsoptions to enum, updated method name
When users are unauthorized they will be redirected to the home page (also the login page). This is not an ideal workflow as it breaks login abstreactions
This code interleaves the google docs api calls into the document fetch workflow. Every so often the we update the reconstruct kvs text with ground truth data from the Google docs api Full commit list from squash: * interweave google api call and more error handling clean up * better documented methods * fixed pycodestyle error
Implemented an alternative approach to module KVSes. This one uses a callable class that can be called as a default KVS() or can specify which KVS to call using KVS.memoization() Full squash commit list: * alternative approach to the KVS dictionary * renamed to kvsrouter and moved initialization logic to class constructor
…rs along that pipeline
Added - CSS linting using stylelint with postscss plugin for `.scss` files - JS linting using eslint - List unused css classes Each of these can be run as an NPM command. Additionally part of this commit also fixes some of the CSS linting errors. Full commit list before squash: * updated linting for css and js and added github action for each and listing unused css classes * updated stylelintrc.json file to address ignoring files and properly parsing scss * updated ignore paths again * added ignore files to stylelint and starting fixing some linting errors * removing extension from linting until we move it to a real build procress * updating unused css ignore paths
* moved docs up a level and included builds for all modules, learning observer, and extra docs * successfully added images, though you have to manually specify each one * updated requirements
* added more logging to comm protocol * updated documentation * added check for target exports
* added detailed logging to communication protocol endpoint * added todo about stripping provenance * added user domain to dashboard log pmss setting * added dashboard_settings.logging_enabled to the reference * added more context to system settings documation * added a few more comments
Added demo module for uploading grades to an LTI service.
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v5.1.0...v5.2.1) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: 5.2.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…231) --- updated-dependencies: - dependency-name: on-headers dependency-version: 1.1.0 dependency-type: indirect - dependency-name: compression dependency-version: 1.8.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ts (#232) Bumps [form-data](https://github.com/form-data/form-data) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/form-data/form-data/releases) - [Changelog](https://github.com/form-data/form-data/blob/v3.0.4/CHANGELOG.md) - [Commits](form-data/form-data@v3.0.2...v3.0.4) --- updated-dependencies: - dependency-name: form-data dependency-version: 3.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ts (#243) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nts (#244) Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.1 to 1.3.2. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ems (#251) * updated keys node in communication protocol to support more scoped items * pr feedback * added documenation regarding how to scope reducers * updated user id related items * more pr feedback * small scope bug fix * fixed mapping dashboard scope issue * more fixes * more fixes
#259) * updated blacklist code to check for domain and determine action by settings * updated maintain to allow numbers
…g with multiple targets (#256) Full commit list * working on making the comm protocol only call nodes in the generator once per run so other nodes can share thoes values * updated shared async iterable to not grow * each target gets their own cleaned generator * updated missing target node error
…nts (#257) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nd added tab metadata reducer Full commit list: * added the tab sepecific code in extension * added tab_id to google doc extension * updated regex for tab ids * added nm command to reconstruct * code for tab_list reducer * added tab scoped time on task * strengthened tab list reducer * added back unnecessary line removals * added back in tab_id to nested structure --------- Co-authored-by: saminur <saminur.islam08@gmail.com>
Full commit list: * added ability to set a single value instead of relying on a list of values * added singleton value so that we can apply it to all remaining scopes * updated single value * added stop check when all scopes are singleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental PR to be able to discuss the whole code base.