Skip to content

Conversation

@bradley-erickson
Copy link
Collaborator

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/ETS-Next-Gen/writing_observer/blob/0a59934066200e3c13fe6c896c159e96a38d6856/modules/wo_classroom_text_highlighter/wo_classroom_text_highlighter/dash_dashboard.py#L66-L68
P0 Badge Await preset layout coroutine before inserting into Dash tree

The preset component’s create_layout function is now async, but the dashboard still calls it synchronously when building the options card. That call returns a coroutine object which Dash cannot serialize or render, so the classroom text highlighter page will fail during layout construction. The call site must await the coroutine (or the function should remain synchronous) to avoid a runtime crash.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant