Skip to content

refactor: prep cli for migration#247

Merged
AnthonyWadham merged 2 commits into
mainfrom
Anthony/DEVP-229-prep-cli-migration
Jul 11, 2025
Merged

refactor: prep cli for migration#247
AnthonyWadham merged 2 commits into
mainfrom
Anthony/DEVP-229-prep-cli-migration

Conversation

@AnthonyWadham

@AnthonyWadham AnthonyWadham commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Refactor: Reorganize CLI code structure

Overview

This PR reorganizes the World CLI codebase into a more standard Go project structure. The code has been moved from a flat structure to a hierarchical one, with packages organized under internal/app/world-cli and shared utilities under internal/pkg. This improves maintainability and follows Go best practices for package organization.

Brief Changelog

  • Moved command implementations from separate packages to a single main package
  • Renamed command structs to be more descriptive (e.g., StartCmdStartCardinalCmd)
  • Relocated core functionality to internal/app/world-cli directory
  • Moved utility packages to internal/pkg directory
  • Removed .vscode/launch.json configuration file
  • Consolidated deployment type constants in the models package
  • Removed unused code and dependencies

Testing and Verifying

This change is a code reorganization without functional changes. The existing tests have been updated to work with the new structure and should continue to pass.

@notion-workspace

Copy link
Copy Markdown

@AnthonyWadham

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add the label graphite/merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AnthonyWadham AnthonyWadham requested a review from ezavada July 10, 2025 21:37
@AnthonyWadham AnthonyWadham marked this pull request as ready for review July 10, 2025 21:37
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch 2 times, most recently from 601634c to cb4f9f5 Compare July 10, 2025 21:45
@AnthonyWadham AnthonyWadham removed the request for review from ezavada July 10, 2025 21:47
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch 16 times, most recently from 515114d to f75ea55 Compare July 10, 2025 23:04
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.30%. Comparing base (fd55650) to head (404c99f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/world-cli/commands/cardinal/start.go 0.00% 12 Missing ⚠️
...nternal/app/world-cli/commands/cloud/deployment.go 70.00% 3 Missing ⚠️
.../app/world-cli/commands/project/region_selector.go 0.00% 2 Missing ⚠️
...ternal/app/world-cli/common/docker/client_image.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   34.77%   41.30%   +6.52%     
==========================================
  Files         123       99      -24     
  Lines        8088     6811    -1277     
==========================================
  Hits         2813     2813              
+ Misses       4984     3707    -1277     
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch 4 times, most recently from 83f9323 to 7fb8bcc Compare July 10, 2025 23:22
Comment thread .github/workflows/ci.yml Fixed
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch from 7fb8bcc to 8a1f3ba Compare July 10, 2025 23:25
Comment thread .github/workflows/ci.yml Fixed
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch from 8a1f3ba to c5568c8 Compare July 10, 2025 23:25
Comment thread .github/workflows/ci.yml Fixed
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch from c5568c8 to 57f30d3 Compare July 10, 2025 23:26
Comment thread .github/workflows/ci.yml Fixed
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch 3 times, most recently from e5ca01f to fb28e2e Compare July 10, 2025 23:33
@AnthonyWadham AnthonyWadham force-pushed the Anthony/DEVP-229-prep-cli-migration branch from fb28e2e to 2453066 Compare July 10, 2025 23:34
@AnthonyWadham AnthonyWadham requested a review from ezavada July 10, 2025 23:38

@ezavada ezavada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I pulled, tried all the tasks, ran all the tests, and everything seems to be working. I did add git ignores for a few files we don't want to check in.

@AnthonyWadham AnthonyWadham merged commit 804252c into main Jul 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants